Upgrade Rails to 7.1 #1540
Upgrade Rails to 7.1 #1540
Conversation
- This PR upgrades the rails version to 7.1
| @@ -0,0 +1,224 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
We can uncomment the changes, that we required.
|
@akhilgkrishnan can you rebase this? |
5f88c26 to
28d0c3c
Compare
Rebased the PR |
|
Specs are failing, @apoorv1316 can you take a look? |
| @@ -115,7 +115,7 @@ gem "active_interaction" | |||
| gem "stripe" | |||
|
|
|||
| # Background job processing adapter | |||
| gem "sidekiq", "<8" | |||
| gem "sidekiq", "~> 7.2" | |||
There was a problem hiding this comment.
Upgraded sidekiq to fix the following error on running sidekiq
super: no superclass method broadcast' for ActiveSupport::Logger:Class`
sidekiq/sidekiq#6054
|
Removed search_service and its specs because we are not using ransack for search. It was old code which was not being used. |
|
@nisusam @prasanthchaduvula @akhilgkrishnan Please review |
Gemfile.lock
Outdated
|
|
||
| PLATFORMS | ||
| arm64-darwin-21 | ||
| arm64-darwin-22 | ||
| arm64-darwin-23 |
There was a problem hiding this comment.
Either get all the relative platforms or remove this
db/schema.rb
Outdated
| @@ -10,7 +10,7 @@ | |||
| # | |||
| # It's strongly recommended that you check this file into your version control system. | |||
|
|
|||
| ActiveRecord::Schema[7.0].define(version: 2024_03_04_143641) do | |||
| ActiveRecord::Schema[7.1].define(version: 2024_03_31_034308) do | |||
There was a problem hiding this comment.
Only single-line change? please check whether the above migrations ran or not.
|
@apoorv1316 @nisusam Are we good to merge this PR? |
will merge tomorrow |