8000 Add and update some conda.txt files by isuruf · Pull Request #39929 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add and update some conda.txt files #39929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2025
Merged

Add and update some conda.txt files #39929

merged 3 commits into from
May 11, 2025

Conversation

isuruf
Copy link
Member
@isuruf isuruf commented Apr 11, 2025

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

cc @dimpase

dimpase
dimpase approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member
@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @roed314 please flip this to positive review

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 11, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 2fe446e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez
Copy link
Contributor

Btw, these conda files are now only used for the docs (and there only in the spkg listing). So in particular version constraints are ignored. We now use the info in

sage/pyproject.toml

Line 101 in 871ba9d

[external]
together with grayskull to generate the conda env. You could do the same for the sagefeedstock, I think.

Was there a particular reason why you had to change these files?

@isuruf
Copy link
Member Author
isuruf commented Apr 14, 2025

I'm using them at 3-manifolds/Sage_macOS#82

@tobiasdiez
Copy link
Contributor

I'm using them at 3-manifolds/Sage_macOS#82

Okay, would it also work if you use the conda env files in the root (eg https://github.com/sagemath/sage/blob/develop/environment-3.12-macos.yml)? They are tested in CI and are thus known to work.

@isuruf
Copy link
Member Author
isuruf 8000 commented Apr 14, 2025

Okay, would it also work if you use the conda env files in the root

No, they are not complete. They do not have optional dependencies nor things like numpy, scipy.

@dimpase
Copy link
Member
dimpase commented Apr 14, 2025

don't you only need non-python dependencies to be provided? the rest, including numpy/scipy, can be pip-installed?

@isuruf
Copy link
Member Author
isuruf commented Apr 14, 2025

the rest, including numpy/scipy, can be pip-installed?

It's better to use conda packages so that everything works seamlessly. For eg: using conda gives us only one blas implementation instead of multiple openblas implementations with the pip wheels.

@tobiasdiez
Copy link
Contributor

Okay, would it also work if you use the conda env files in the root

No, they are not complete. They do not have optional dependencies nor things like numpy, scipy.

The optional dependencies were indeed missing. Fixed in #39944.

Numpy and scipy are already included in these env files.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2025
70dce7f 
sagemathgh-39929: Add and update some conda.txt files
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

cc @dimpase
    
URL: sagemath#39929
Reported by: Isuru Fernando
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
8e9e276 
sagemathgh-39929: Add and update some conda.txt files
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

cc @dimpase
    
URL: sagemath#39929
Reported by: Isuru Fernando
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
f0e8388 
sagemathgh-39929: Add and update some conda.txt files
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

cc @dimpase
    
URL: sagemath#39929
Reported by: Isuru Fernando
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit d5eef25 into sagemath:develop May 11, 2025
25 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isuruf @tobiasdiez @dimpase @vbraun
0