8000 Update conda lock files by tobiasdiez · Pull Request #39993 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update conda lock files #39993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 1, 2025
Merged

Update conda lock files #39993

merged 8 commits into from
Jun 1, 2025

Conversation

tobiasdiez
Copy link
Contributor
@tobiasdiez tobiasdiez commented Apr 21, 2025

Update lock file. On macos there is a new warning due to duplicate rpaths, which is ignored by using code from #36337.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 078ce61; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@antonio-rojas
Copy link
Contributor

The CI issues are (were) caused by the atlasrep web site https://www.math.rwth-aachen.de/homes/Thomas.Breuer/atlasrep/ being down, which makes gap hang when trying to remotely fetch the atlas data. The website is back up now, but I find it quite shocking that a remote website being down can break running a local instance of GAP.

@tobiasdiez
Copy link
Contributor Author

The CI issues are (were) caused by the atlasrep web site https://www.math.rwth-aachen.de/homes/Thomas.Breuer/atlasrep/ being down, which makes gap hang when trying to remotely fetch the atlas data. The website is back up now, but I find it quite shocking that a remote website being down can break running a local instance of GAP.

Ah, thanks. This explains why the error occurred without any changes on our side. Not sure where to report the underlying issue. @dimpase any idea?

@tobiasdiez tobiasdiez requested a review from dimpase May 10, 2025 03:31
@tobiasdiez
Copy link
Contributor Author

So, tests are passing (except of course the usual random issues). Hence, ready for review.

Copy link
Member
@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me

@tobiasdiez
Copy link
Contributor Author

Thanks!

@vbraun
Copy link
Member
vbraun commented May 18, 2025

merge conflict, please fix

@tobiasdiez
Copy link
Contributor Author

merge conflict, please fix

Done. Setting back to positive review.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 24, 2025
sagemathgh-39993: Update conda lock files
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Update lock file. On macos there is a new warning due to duplicate
rpaths, which is ignored by using code from
sagemath#36337.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39993
Reported by: Tobias Diez
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request May 26, 2025
sagemathgh-39993: Update conda lock files
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Update lock file. On macos there is a new warning due to duplicate
rpaths, which is ignored by using code from
sagemath#36337.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39993
Reported by: Tobias Diez
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request May 28, 2025
sagemathgh-39993: Update conda lock files
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Update lock file. On macos there is a new warning due to duplicate
rpaths, which is ignored by using code from
sagemath#36337.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39993
Reported by: Tobias Diez
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit 9d547e2 into sagemath:develop Jun 1, 2025
12 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0