8000 Refactor imports in PoorManMap and Sequence classes by tobiasdiez · Pull Request #39989 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor imports in PoorManMap and Sequence classes #39989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

tobiasdiez
Copy link
Contributor

Minor refactoring to prefer importing the object (from sage.structure.sage_object import SageObject) over the module (import sage.structure.sage_object).

Part of making all sage modules import without sage.all.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link
github-actions bot commented Apr 21, 2025

Documentation preview for this PR (built with commit b275f17; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton fchapoton self-assigned this Apr 21, 2025
Copy link
Contributor
@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@tobiasdiez
Copy link
Contributor Author

Thanks for the review!

@vbraun vbraun merged commit a5b9756 into sagemath:develop Apr 29, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0