8000 add some typing annotations in modular folder by fchapoton · Pull Request #39987 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add some typing annotations in modular folder #39987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

add some typing annotations in modular folder #39987

merged 2 commits into from
Apr 29, 2025

Conversation

fchapoton
Copy link
Contributor

This is adding the -> bool annotation to many functions and methods in the modular folder.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
8000 Copy link
github-actions bot commented Apr 21, 2025 •
edited
Loading

Documentation preview for this PR (built with commit e12041c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vincentmacri
vincentmacri suggested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor
@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just two functions I think were annotated incorrectly.

vincentmacri
vincentmacri approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor
@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit edf324e into sagemath:develop Apr 29, 2025
21 of 22 checks passed
@fchapoton fchapoton deleted the typing_is_in_modular branch April 30, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentmacri vincentmacri vincentmacri approved these changes

Assignees
No one assigned
Labels
c: modular forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @vincentmacri @vbraun
0