8000 fix again the pycodestyle linter by fchapoton · Pull Request #39968 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix again the pycodestyle linter #39968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

fchapoton
Copy link
Contributor

that was just slightly broken recently

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link
Contributor
@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to set to positive review once the tests are green.

Copy link

Documentation preview for this PR (built with commit 98b2e46; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton fchapoton added s: positive review p: CI Fix merged before running CI tests and removed s: needs review p: CI Fix merged before running CI tests labels Apr 20, 2025
@fchapoton
Copy link
Contributor Author

It seems that the pycodestyle check has been removed and so immediatly started failiing.

@tobiasdiez
Copy link
Contributor

You can try to activate the corresponding ruff rule like https://docs.astral.sh/ruff/rules/blank-lines-after-function-or-class/

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 21, 2025
sagemathgh-39968: fix again the pycodestyle linter
    
that was just slightly broken recently

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39968
Reported by: Frédéric Chapoton
Reviewer(s): Tobias Diez
@vbraun vbraun merged commit f7131a8 into sagemath:develop Apr 29, 2025
23 of 24 checks passed
@fchapoton fchapoton deleted the fixin_the_linter branch April 30, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0