8000 typing and details in tableaux files by fchapoton · Pull Request #39477 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

typing and details in tableaux files #39477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

fchapoton
Copy link
Contributor

add -> bool typing to some methods in three files related to tableaux

also very minor code details

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link
github-actions bot commented Feb 7, 2025

Documentation preview for this PR (built with commit 033c93b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator
@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 11, 2025
sagemathgh-39477: typing and details in tableaux files
    
add `-> bool` typing to some methods in three files related to tableaux

also very minor code details

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39477
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 18, 2025
sagemathgh-39477: typing and details in tableaux files
    
add `-> bool` typing to some methods in three files related to tableaux

also very minor code details

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39477
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 11ee7ca into sagemath:develop Feb 21, 2025
22 of 23 checks passed
@fchapoton fchapoton deleted the tableau_typ branch February 22, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0