8000 Add wrapper for FLINT's `acb_dirichlet_zeta_zeros` by lairez · Pull Request #39391 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add wrapper for FLINT's acb_dirichlet_zeta_zeros #39391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Add wrapper for FLINT's acb_dirichlet_zeta_zeros #39391

merged 1 commit into from
Feb 10, 2025

Conversation

lairez
Copy link
Contributor
@lairez lairez commented Jan 27, 2025 •
edited
Loading

New method ComplexBallField.zeta_zeros that wraps acb_dirichlet_zeta_zeros for computing zeros of the Rieman ζ function.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mezzarobba mezzarobba self-assigned this Jan 28, 2025
@lairez
Copy link
Contributor Author
lairez commented Jan 28, 2025

I updated the PR following a discussion with @mezzarobba

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 28, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 0625fc1; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mezzarobba
mezzarobba reviewed Jan 28, 2025
View reviewed changes
Copy link
Member
@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm up to some typos in the docstring

src/sage/rings/complex_arb.pyx Outdated
@@ -1261,6 +1262,70 @@ class ComplexBallField(UniqueRepresentation, sage.rings.abc.ComplexBallField):

return res

def zeta_zeros(self, count, start=1):
r"""
Compute a consecutive zeros of the Riemann zeta function.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

src/sage/rings/complex_arb.pyx Outdated

INPUT:

- ``count`` -- positive integer; number of zeros to be computed, must fit a machine integer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"fit in"?

@lairez
Add wrapper for FLINT's acb_dirichlet_zeta_zeros
0625fc1 
New method `ComplexBallField.zeta_zeros` that wraps
`acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2025
sagemathgh-39391: Add wrapper for FLINT's acb_dirichlet_zeta_zeros
6961e16 
New method `ComplexBallField.zeta_zeros` that wraps
`acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#39391
Reported by: Pierre Lairez
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2025
5448c83 
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros`
    
New method `ComplexBallField.zeta_zeros` that wraps
`acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39391
Reported by: Pierre Lairez
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 31, 2025
59bf01f 
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros`
    
New method `ComplexBallField.zeta_zeros` that wraps
`acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39391
Reported by: Pierre Lairez
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 3, 2025
8320fa9 
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros`
    
New method `ComplexBallField.zeta_zeros` that wraps
`acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39391
Reported by: Pierre Lairez
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 4, 2025
5b9670a 
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros`
    
New method `ComplexBallField.zeta_zeros` that wraps
`acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39391
Reported by: Pierre Lairez
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
9b61b74 
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros`
    
New method `ComplexBallField.zeta_zeros` that wraps
`acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39391
Reported by: Pierre Lairez
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
deea8e3 
sagemathgh-39391: Add wrapper for FLINT's `acb_dirichlet_zeta_zeros`
    
New method `ComplexBallField.zeta_zeros` that wraps
`acb_dirichlet_zeta_zeros` for computing zeros of the Rieman ζ function.

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39391
Reported by: Pierre Lairez
Reviewer(s): Marc Mezzarobba
@vbraun vbraun merged commit 66310c6 into sagemath:develop Feb 10, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mezzarobba mezzarobba mezzarobba approved these changes

Assignees

@mezzarobba mezzarobba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lairez @mezzarobba @vbraun
0