8000 Remove old deprecations in `algebras` and `categories` by tobiasdiez · Pull Request #39263 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove old deprecations in algebras and categories #39263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Remove old deprecations in algebras and categories #39263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions src/sage/algebras/algebra.py
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/sage/algebras/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
py.install_sources(
'__init__.py',
'affine_nil_temperley_lieb.py',
'algebra.py',
'all.py',
'askey_wilson.py',
'associated_graded.py',
Expand Down
26 changes: 4 additions & 22 deletions src/sage/categories/modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,16 +967,10 @@ def construction(self):
(Free Algebra on 2 generators (None0, None1) over Rational Field,
Free Algebra on 2 generators (None0, None1) over Rational Field))
"""
try:
factors = self.tensor_factors()
except (TypeError, NotImplementedError):
from sage.misc.superseded import deprecation
deprecation(34393, "implementations of Modules().TensorProducts() now must define the method tensor_factors")
return None
return (TensorProductFunctor(),
factors)

@abstract_method(optional=True)
factors = self.tensor_factors()
return (TensorProductFunctor(), factors)

@abstract_method
def tensor_factors(self):
"""
Return the tensor factors of this tensor product.
Expand All @@ -992,16 +986,4 @@ def tensor_factors(self):
F # G
sage: T.tensor_factors()
(F, G)

TESTS::

sage: Cat = ModulesWithBasis(ZZ).FiniteDimensional().TensorProducts()
sage: M = CombinatorialFreeModule(ZZ, # needs sage.modules
....: ((1, 1), (1, 2), (2, 1), (2, 2)),
....: category=Cat)
sage: M.construction() # needs sage.modules
doctest:warning...
DeprecationWarning: implementations of Modules().TensorProducts() now must define the method tensor_factors
See https://github.com/sagemath/sage/issues/34393 for details.
(VectorFunctor, Integer Ring)
"""
Loading
0