Fix tests with scipy 1.15 #39261
Merged
Fix tests with scipy 1.15 #39261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase numerical tolerance in one test, and replace usage of deprecated `sph_harm` in another one
kiwifb
reviewed
Jan 4, 2025
| ....: sph_harm(1, 1, pi.n(), (pi/2).n()) # abs tol 1e-14 # needs scipy sage.symbolic | ||
| ....: else: | ||
| ....: from scipy.special import sph_harm_y # needs scipy | ||
| ....: sph_harm_y(1, 1, (pi/2).n(), pi.n()).item() # abs tol 1e-9 # needs scipy sage.symbolic |
There was a problem hiding this comment.
Instead of importing scipy.version, what about using a very pythonic way of doing thing like
try:
from scipy.special import sph_harm_y
sph_harm_y(1, 1, (pi/2).n(), pi.n()).item() # abs tol 1e-9
except ImportError:
from scipy.special import sph_harm
sph_harm(1, 1, pi.n(), (pi/2).n()) # abs tol 1e-14
?
There was a problem hiding this comment.
not sure, IMO this is easier to keep track of for future cleanups (when sage requires scipy>=1.15)
There was a problem hiding this comment.
Sounds like a fairly good argument.
There was a problem hiding this comment.
I agree...
It would be useful to have tags for different program versions to avoid having to use conditionals in the doctests (just like "32-bit" and "64-bit" labels). This is not only doctest but also documentation, and it looks kind of ugly. With labels, perhaps the manual could show only the version that matches currently installed software or something like that...
|
Documentation preview for this PR (built with commit de24001; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2025
sagemathgh-39261: Fix tests with scipy 1.15 Increase numerical tolerance in one test, and replace usage of deprecated `sph_harm` in another one URL: sagemath#39261 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, François Bissey, Gonzalo Tornaría
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
sagemathgh-39261: Fix tests with scipy 1.15 Increase numerical tolerance in one test, and replace usage of deprecated `sph_harm` in another one URL: sagemath#39261 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, François Bissey, Gonzalo Tornaría
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
sagemathgh-39261: Fix tests with scipy 1.15 Increase numerical tolerance in one test, and replace usage of deprecated `sph_harm` in another one URL: sagemath#39261 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, François Bissey, Gonzalo Tornaría
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
sagemathgh-39261: Fix tests with scipy 1.15 Increase numerical tolerance in one test, and replace usage of deprecated `sph_harm` in another one URL: sagemath#39261 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, François Bissey, Gonzalo Tornaría
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
sagemathgh-39261: Fix tests with scipy 1.15 Increase numerical tolerance in one test, and replace usage of deprecated `sph_harm` in another one URL: sagemath#39261 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, François Bissey, Gonzalo Tornaría
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
sagemathgh-39261: Fix tests with scipy 1.15 Increase numerical tolerance in one test, and replace usage of deprecated `sph_harm` in another one URL: sagemath#39261 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, François Bissey, Gonzalo Tornaría
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase numerical tolerance in one test, and replace usage of deprecated
sph_harmin another one