8000 Add developer tools to conda environment by tobiasdiez · Pull Request #39141 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add developer tools to conda environment #39141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 22, 2025
Merged

Add developer tools to conda environment #39141

merged 4 commits into from
Mar 22, 2025

Conversation

tobiasdiez
Copy link
Contributor
@tobiasdiez tobiasdiez commented Dec 16, 2024 •
edited
Loading

Add a few dependencies needed for some developer tooling and/or linting.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tobiasdiez
Add developer tools to conda environment
56fe3d0 
Add a few dependencies needed for some developer tooling and/or linting.
@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 16, 2024 •
edited
Loading

Documentation preview for this PR (built with commit c56e963; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor

Not sure if this is desirable, sometimes some user just want to build from source without doing development work.

@tobiasdiez
Copy link
Contributor Author

Not sure if this is desirable, sometimes some user just want to build from source without doing development work.

We had a separate -dev environment in the past, but it generated quite a bit of maintenance overhead.

In which scenarios do you think someone would like to build sage from source using conda for dependencies, but not actually work on sage? (In particular, why would she not just install the distributed sage-on-conda?) In this case, would it be so inconvenient to also install a couple of dev tools?

@user202729
Copy link
Contributor

I see. They're just some theoretical considerations.

@tobiasdiez
Copy link
Contributor Author

I see. They're just some theoretical considerations.

Thanks a lot for bringing them up!

--

The tests fail because of sagemath/cysignals#212, which is fixed in sagemath/cysignals#213.

@saraedum
Copy link
Member

@tobiasdiez is this ready for review?

@tobiasdiez
Copy link
Contributor Author

@tobiasdiez is this ready for review?

Not quite yet, it needs #38749 first.

@vbraun vbraun merged commit c54728e into sagemath:develop Mar 22, 2025
14 of 20 checks passed
@tobiasdiez tobiasdiez deleted the add-dev-tools branch March 22, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasdiez @user202729 @saraedum @vbraun
0