Fix the right-border on unicode tables #39023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like during the conversion to unicode, the right borders of table cells were overlooked. Instead of a nice unicode character, they still have an ASCII pipe. For example, sage: table([1],frame=True) ┌───┐ │ 1 | └───┘ This commit changes it to a unicode thingy, just like the left borders, sage: table([1],frame=True) ┌───┐ │ 1 │ └───┘ and updates all of the tests in sage.misc.table.
The right borders of table cells have been updated to use unicode instead of an ASCII pipe, so any tests that print tables need to be changed.
|
Documentation preview for this PR (built with commit c5d9fc2; changes) is ready! 🎉 |
user202729
approved these changes
Nov 23, 2024
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 6, 2024
sagemathgh-39023: Fix the right-border on unicode tables Turn ``` sage: table([1],frame=True) ┌───┐ │ 1 | └───┘ ``` into ``` sage: table([1],frame=True) ┌───┐ │ 1 │ └───┘ ``` which should look a bit better (depends on your font) and is more consistent (the left and right borders now match). URL: sagemath#39023 Reported by: Michael Orlitzky Reviewer(s): Martin Rubey, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 8, 2024
sagemathgh-39023: Fix the right-border on unicode tables Turn ``` sage: table([1],frame=True) ┌───┐ │ 1 | └───┘ ``` into ``` sage: table([1],frame=True) ┌───┐ │ 1 │ └───┘ ``` which should look a bit better (depends on your font) and is more consistent (the left and right borders now match). URL: sagemath#39023 Reported by: Michael Orlitzky Reviewer(s): Martin Rubey, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn
into
which should look a bit better (depends on your font) and is more consistent (the left and right borders now match).