one more method in FHM-triangles #39020
Conversation
|
Documentation preview for this PR (built with commit a3ea981; changes) is ready! 🎉 |
|
@tscrim : would you have time for this easy one, please ? |
src/sage/combinat/triangles_FHM.py
Outdated
| x, y = self._vars | ||
| polyf = self._poly(y=y - 1) | ||
| return F_triangle(polyf, variables=(x, y)) |
There was a problem hiding this comment.
| x, y = self._vars | |
| polyf = self._poly(y=y - 1) | |
| return F_triangle(polyf, variables=(x, y)) | |
| y = self._vars[-1] | |
| polyf = self._poly(y=y - 1) | |
| return F_triangle(polyf, variables=self._vars) |
Can you also add a test when the variables are not x,y; say a,b? I am worried about the substitution line. It might need to be self._poly(**{str(y): y}).
There was a problem hiding this comment.
ah, right.. I am afraid that the whole file is not robust with respect to the use of other variable names. There are many substitutions where I use x=.. and / or y=....
Should I fix them all here ?
There was a problem hiding this comment.
Up to you. At least for this method we should do it here. Probably best to do it en masse here though...
sagemathgh-39020: one more method in FHM-triangles just adding a small easy method ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39020 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
sagemathgh-39020: one more method in FHM-triangles just adding a small easy method ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39020 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
just adding a small easy method
📝 Checklist