8000 Raise a power series to a power series by trevorkarn · Pull Request #36773 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Raise a power series to a power series #36773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? < 8000 a data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"new issue modal","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/sagemath/sage/pull/36773","user_id":null}}" data-hydro-click-hmac="34ba475a6f8e5f57d5d433f21d47267b74f570f412e276497027a5205d9c0e20" class="Link--inTextBlock" href="/login?return_to=%2Fsagemath%2Fsage%2Fissues%2Fnew%2Fchoose">Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Raise a power series to a power series #36773

wants to merge 3 commits into from

Conversation

trevorkarn
Copy link
Contributor

This adds the functionality to compute the power series f^g when it is well defined.

This adds functionality that is useful for generating function computations.

Fixes #36772.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

N/A

@trevorkarn trevorkarn self-assigned this Nov 26, 2023
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit cd6d553; changes) is ready! 🎉

@trevorkarn trevorkarn requested a review from tscrim December 21, 2023 16:45
@trevorkarn
Copy link
Contributor Author

As I understand it, the lint issues are coming from other portions of the code than what I changed.

tscrim
tscrim requested changes Dec 22, 2023
View reviewed changes
src/sage/rings/power_series_ring_element.pyx
right = QQ.coerce(r)
except TypeError:
raise ValueError("exponent must be a rational number")
if parent(r) is self.parent() or QQ.has_coerce_map_from(parent(r)):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to split things up into cases with a bit more care. I would first test if r can be coerced into QQ and then run that case. Then if that is not the case, check if r can be coerced into self.parent() and if so then do the $\exp(r \log)$. The reason for the care is that things that coerce into QQ might also coerce into self.parent() (which I expect the general case to be slower). In both cases, I would probably do it by try-except blocks.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is a good solution to manage all the cases

@Pietro-D
Copy link
Pietro-D commented Feb 16, 2024 •
edited
Loading

As I understand it, the lint issues are coming from other portions of the code than what I changed.

The lint issues are related to some trailing spaces in your code

@JohnCremona JohnCremona removed their request for review April 29, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pietro-D Pietro-D Pietro-D left review comments

@tscrim tscrim tscrim requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@trevorkarn trevorkarn

Labels
c: algebra c: combinatorics s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise a power series to a power series
3 participants
@trevorkarn @Pietro-D @tscrim
0