8000 Fix RealLiteral to float conversion by user202729 · Pull Request #40279 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix RealLiteral to float conversion #40279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix RealLiteral to float conversion #40279

wants to merge 1 commit into from

Conversation

user202729
Copy link
Contributor
@user202729 user202729 commented Jun 21, 2025 •
edited
Loading

Previously we see the following behavior

        sage: float(1.133759543500045e+153)
        1.1337595435000451e+153

This is because RealLiteral constructor determine prec=54, so the string 1.133759543500045e+153 is first converted to 54 bits, then rounded to 53 bits. This introduces the error because of double rounding.

Also fix the issue where n(RealNumber('12', base=16)) returns 12. (now it correctly returns 18.)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit c91f3a8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@user202729
0