8000 Trac #40127: Pass factor_on_left in linear_combination by local-ring · Pull Request #40173 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Trac #40127: Pass factor_on_left in linear_combination #40173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2025
Merged

Trac #40127: Pass factor_on_left in linear_combination #40173

merged 3 commits into from
Jun 1, 2025

Conversation

local-ring
Copy link
Contributor
@local-ring local-ring commented May 27, 2025 •
edited
Loading

Fixes #40127.

Passes factor_on_left correctly to iaxpy() in linear_combination.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@local-ring
Copy link
Contributor Author

cc: @tscrim could you review this PR? Thanks!

tscrim
tscrim requested changes May 28, 2025
View reviewed changes
Copy link
Collaborator
@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a doctest showing this works, say, using coefficients in SGA = SymmetricGroupAlgebra(3). Otherwise this is good with me.

@local-ring
Copy link
Contributor Author

We should add a doctest showing this works, say, using coefficients in SGA = SymmetricGroupAlgebra(3). Otherwise this is good with me.

Thanks for suggesting that. It is a good idea, and I added the example in docstring as you advised.

@local-ring local-ring requested a review from tscrim May 28, 2025 03:51
tscrim
tscrim approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator
@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Positive review.

@vbraun vbraun merged commit 5b324d1 into sagemath:develop Jun 1, 2025
11 of 21 checks passed
@user202729
Copy link
Contributor

By the way we just call "trac" issue now. I thought we change all the mentions in the documentation already?

@local-ring
Copy link
Contributor Author

By the way we just call "trac" issue now. I thought we change all the mentions in the documentation already?

Ok gotcha, thanks for pointing this out. Will use "issue" in the future. What documentation did you mean?

@user202729
Copy link
Contributor

Ok gotcha, thanks for pointing this out. Will use "issue" in the future. What documentation did you mean?

As in unless you've been contributing to SageMath for a few years (back when we were still using trac) you likely wouldn't have heard of the word "trac" at all. Just asking if you have read it from somewhere, in that case the source should be updated.

@local-ring
Copy link
Contributor Author

Ok gotcha, thanks for pointing this out. Will use "issue" in the future. What documentation did you mean?

As in unless you've been contributing to SageMath for a few years (back when we were still using trac) you likely wouldn't have heard of the word "trac" at all. Just asking if you have read it from somewhere, in that case the source should be updated.

I see, i borrow the "trac" word from the advice from chatgpt on polishing my pr. I didn't read it from somewhere. Apprarently it read this from some very old sagemath pr I guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

factor_on_left in linear_combination is not passed to iaxpy
4 participants
@local-ring @user202729 @tscrim @vbraun
0