Jacobi theta functions implemented as lazy series #40093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mantepse Here is a special function with lots of good identities that require quite a bit of the machinery we've developed. Although we should figure out a way to share the parent-level special function methods between the |
mantepse
reviewed
May 13, 2025
mantepse
reviewed
May 13, 2025
mantepse
reviewed
May 13, 2025
mantepse
reviewed
May 13, 2025
|
beautiful! |
|
Thank you. I have fixed them all. |
|
Thank you. |
|
PDF docs don't build |
|
Okay, that was a bad latex mistake on my part. Hopefully the bot will actually work to check the pdf build this time… |
7ac2664 to
724e9ee
Compare
|
is there a way to fix the ci? |
|
@mantepse I wish I knew. I keep trying to re-run it, but it doesn't seem to be something local to this PR. I could verify it locally if I wanted to test it, but I don't really want to... ^^;; |
5 tasks
mantepse
reviewed
May 22, 2025
src/sage/rings/lazy_series_ring.py
Outdated
| + 108810*q^15 + O(q^16) | ||
| sage: LHS[:30] == RHS[:30] | ||
| True | ||
|
|
|
@fchapoton, codespell complains about "nome" (and suggests "gnome"). Is there a way to fix that? |
|
do you mean your local codespell ? i don't think we run codespell in the CI. There are config files in src, namely src/.codespell-ignore.txt |
Ah, cool. OK, but if codespell is not run in the CI, I guess it is better not to add |
|
Looks great except for the whitespace! |
|
Thank you. I have removed the trailing whitespace. Based on your comment, I am allowing myself to set this to a positive review. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 26, 2025
sagemathgh-40093: Jacobi theta functions implemented as lazy series <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> An important special function $\vartheta_{ab}(z; \tau)$, which can be considered as a (formal) power series in terms of the nome $q = e^{\pi i \tau}$ with coefficient parameter $w = e^{\pi i z}$. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40093 Reported by: Travis Scrimshaw Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-40093: Jacobi theta functions implemented as lazy series <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> An important special function $\vartheta_{ab}(z; \tau)$, which can be considered as a (formal) power series in terms of the nome $q = e^{\pi i \tau}$ with coefficient parameter $w = e^{\pi i z}$. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40093 Reported by: Travis Scrimshaw Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40141: Adding the polylogarithm as lazy series <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Another special function that is important in many areas of math. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40093: Adds to the same places in the files. URL: sagemath#40141 Reported by: Travis Scrimshaw Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40141: Adding the polylogarithm as lazy series <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Another special function that is important in many areas of math. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40093: Adds to the same places in the files. URL: sagemath#40141 Reported by: Travis Scrimshaw Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 13, 2025
sagemathgh-40141: Adding the polylogarithm as lazy series <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Another special function that is important in many areas of math. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40093: Adds to the same places in the files. URL: sagemath#40141 Reported by: Travis Scrimshaw Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An important special function$\vartheta_{ab}(z; \tau)$ , which can be considered as a (formal) power series in terms of the nome $q = e^{\pi i \tau}$ with coefficient parameter $w = e^{\pi i z}$ .
📝 Checklist
⌛ Dependencies