8000 Use async-channel or flume · Issue #18 · sagebind/sluice · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use async-channel or flume #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nullchinchilla opened this issue Aug 2, 2021 · 2 comments · Fixed by #19
Closed

Use async-channel or flume #18

nullchinchilla opened this issue Aug 2, 2021 · 2 comments · Fixed by #19
Labels
enhancement New feature or request

Comments

@nullchinchilla
Copy link

futures-channel is known to be of poor performance; would using async-channel or flume be considered?
@sagebind
Copy link
Owner
sagebind commented Aug 2, 2021

Certainly! Sluice was initially written before either async-channel or flume were created, but those are both better options than futures-channel today. I usually prefer async-channel since flume has a heavier dependency tree.

@sagebind sagebind added the enhancement New feature or request label Aug 2, 2021
sagebind added a commit that referenced this issue Aug 15, 2021
@sagebind
Switch channel implementation to async-channel
2549df1 
Switch the underlying channel implementation from futures-channel to async-channel, since the former has been shown to fall behind on performance metrics. In addition, crates from the futures project tend to have slower compile times compared to some alternatives.

Fixes #18.
@sagebind sagebind mentioned this issue Aug 15, 2021
Merged
sagebind added a commit that referenced this issue Aug 15, 2021
@sagebind
Switch channel implementation to async-channel (#19)
cdb8ef3 
Switch the underlying channel implementation from futures-channel to async-channel, since the former has been shown to fall behind on performance metrics. In addition, crates from the futures project tend to have slower compile times compared to some alternatives.

Fixes #18.
@sagebind
Copy link
Owner

Thanks for the suggestion! Sluice now uses async-channel under the hood in version 0.5.5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch channel implementation to async-channel sagebind/sluice
2 participants
@sagebind @nullchinchilla
0