[pull] master from samba-team:master #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15727 Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Apr 23 12:14:17 UTC 2025 on atb-devel-224
…sibility (part 2) This commit introduces significant enhancements to our logging system to improve debugging capabilities and provide better visibility into the code's execution flow. This is part 2 for logging improvement. There have already been some logging improvements done in the past. https://gitlab.com/samba-team/samba/-/merge_requests/3948 This commit includes following key changes. Expanded a logging message 1) Every function entry and exit point. 2) Error Path / Error handling blocks. 3) Key decision branches (if/else statements). Consistent logging. 1) Logging message to print either the file/dir name its feasible. 2) Standardized log message formatting to ensure consistency and readability. This makes it easier to scan and understand log output. Impact This enhancement will reduce the time required to diagnose and resolve issues. It will provide valuable insights into the system's behavior, enabling us to optimize performance and improve user experience. Signed-off-by: Shweta Sodani <ssodani@redhat.com> Reviewed-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Mon Apr 28 07:04:15 UTC 2025 on atb-devel-224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )