8000 Add cell balance sensors by jingsno · Pull Request #46 · syssi/esphome-pace-bms · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add cell balance sensors #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

jingsno
Copy link
Contributor
@jingsno jingsno commented Aug 14, 2024

Adds cell balance sensors to ESP32 Code

image

Lovlace example:
image

Adds cell balance sensors to ESP32 Code
@syssi
Copy link
Owner
syssi commented Aug 14, 2024

Thanks for your contribution! Could you extend the ESP8266 configration YAML too?

@jingsno
Copy link
Contributor Author
jingsno commented Aug 14, 2024

Added cell balance sensors to esp8266-example.yaml aswell.
(Please note that the existing binary sensors for charging / discharging is different in the ESP32 and the ESP8266 yaml. I presume the ESP32 sensors are the correct ones, and that the ESP8266 code has not been updated?)

@syssi
Copy link
Owner
syssi commented Aug 14, 2024

Please note that the existing binary sensors for charging / discharging is different in the ESP32 and the ESP8266 yaml. I presume the ESP32 sensors are the correct ones, and that the ESP8266 code has not been updated?

This isn't intended. The idea is two equal YAMLs just for difference microcontrollers. If you have the chance I'm happy about a second merge request to fix this issue.

@syssi syssi merged commit 3016ad1 into syssi:main Aug 14, 2024
3 checks passed
@jingsno jingsno deleted the add-cell-balance-sensors branch August 14, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0