Use Single scale on vectorized icon + Defaults binding #199
Conversation
There was a problem hiding this comment.
PR Summary
This PR standardizes SVG icon handling across the application by adding vector preservation properties and simplifying scale factors, while also improving defaults binding in the settings UI.
- Added
preserves-vector-representation: trueto all SVG icon assets in/macos/Onit/Assets.xcassets/Icons/to maintain vector quality across resolutions - Removed redundant scale factors (1x, 2x, 3x) from SVG assets since they are inherently scalable
- Simplified toggle bindings in
/macos/Onit/UI/Settings/AccessibilityTab.swiftby using SwiftUI's $-prefix syntax for @default properties - Removed unused icon assets like
circle-arrow-up-20.imagesetandcircle-arrow-up-dotted-no-padding.imageset
53 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| "properties" : { | ||
| "preserves-vector-representation" : true | ||
| } |
There was a problem hiding this comment.
style: Consider adding this 'preserves-vector-representation' property to all other SVG icon assets in the PR for consistency
| @@ -2,20 +2,14 @@ | |||
| "images" : [ | |||
| { | |||
| "filename" : "Vector (59).svg", | |||
There was a problem hiding this comment.
style: Consider renaming 'Vector (59).svg' to 'text-quotations.svg' for consistency with other icon filenames
| "filename" : "Vector (59).svg", | |
| "filename" : "text-quotations.svg", |
| @@ -2,20 +2,14 @@ | |||
| "images" : [ | |||
| { | |||
| "filename" : "triangle-exclamation, error, warning, alert (1).svg", | |||
There was a problem hiding this comment.
style: Consider renaming the file to something more concise like 'warning.svg' instead of 'triangle-exclamation, error, warning, alert (1).svg' for better maintainability
No description provided.