[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] removed whitespace .tableform.py #26468

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Fix] removed whitespace .tableform.py #26468

wants to merge 3 commits into from

Conversation

samuelard7
Copy link
Contributor
@samuelard7 samuelard7 commented Apr 5, 2024 •
edited
Loading

References to other Issues or PRs

Brief description of what is fixed or changed

-> Problem with whitespace for some test cases
in tableform.py

Other comments

Release Notes

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

  • solvers

    • Removed the whitespace.

  • functions

    • changes in _align.

@samuelard7
Fix removed whitespace tableform.py
cad2b9b 
Problem with whitespace for some test cases
@sympy-bot
Copy link
sympy-bot commented Apr 5, 2024 •
edited
Loading

✅

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed. 
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

-> Problem with whitespace for some test cases
in tableform.py

#### Other comments


#### Release Notes


See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
  * Removed the whitespace.

* functions
  * changes in _align.
<!-- END RELEASE NOTES -->

samuelard7

This comment was marked as resolved.

Sign in to view

@samuelard7 samuelard7 changed the title Fix removed whitespace tableform.py [Fix] removed whitespace .tableform.py Apr 5, 2024
@smichr
Copy link
Member
smichr commented Apr 6, 2024

Please add a test that would be different now than in master.

@samuelard7
Copy link
Contributor Author

Please add a test that would be different now than in master.

Sure, I want to ask why the test/author failed I already added my name and email on .mailmap file

@oscarbenjamin
Copy link
Collaborator

why the test/author failed

The error in the CI job is:

The mailmap file was reordered

    For instructions on updating the .mailmap file see:

https://docs.sympy.org/dev/contributing/new-contributors-guide/workflow-process.html#mailmap-instructions

You need to rerun the script so that the file is in order. This is needed because otherwise everyone chooses (as you did) to add their names at the end of the file which would lead to constant merge conflicts between different PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelard7 @sympy-bot @smichr @oscarbenjamin