Replace "resolve_url_loader" by "resolveUrlLoader" #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
requested changes
Sep 14, 2017
There was a problem hiding this comment.
This is just awesome. I really wanted to start the habit/system of deprecating things when possible, even though we are before 1.0. And you were obviously thinking the exact same thing. Nice work! One tiny comment, which I think you'll like. Then we're ready!
lib/WebpackConfig.js
Outdated
| throw new Error(`Invalid option "${optionKey}" passed to enableSassLoader(). Valid keys are ${Object.keys(this.sassOptions).join(', ')}`); | ||
| let normalizedOptionKey = optionKey; | ||
| if (optionKey === 'resolve_url_loader') { | ||
| logger.warning('enableSassLoader: "resolve_url_loader" is deprecated. Please use "resolveUrlLoader" instead.'); |
There was a problem hiding this comment.
How about a new logger.deprecation method? It will probably look the same, but can be a nice, standard way to start doing this
8000
Lyrkan
force-pushed
the
deprecate-resolve_url_loader
branch
from
September 14, 2017 19:45
77d6f42 to
ff442a6
Compare
Lyrkan
commented
Sep 14, 2017
| resolve_url_loader: true | ||
| resolveUrlLoader: true | ||
| }; | ||
| this.preactOptions = { |
|
Awesome. Thank you @Lyrkan! |
weaverryan
added a commit
that referenced
this pull request
Sep 14, 2017
This PR was squashed before being merged into the master branch (closes #159). Discussion ---------- Replace "resolve_url_loader" by "resolveUrlLoader" This PR deprecates the `resolve_url_loader` option used by the `enableSassLoader` and replaces it by `resolveUrlLoader`. This is done to be consistent with other methods that use camel-case instead of snake-case (see [#152](#152 (comment))). `resolve_url_loader` will still work for now but will display the following deprecation message:  Commits ------- ff442a6 Add a logger.deprecation(message) method 9dac153 Replace sass option 'resolve_url_loader' by 'resolveUrlLoader'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
resolve_url_loaderoption used by theenableSassLoaderand replaces it byresolveUrlLoader.This is done to be consistent with other methods that use camel-case instead of snake-case (see #152).
resolve_url_loaderwill still work for now but will display the following deprecation message: