8000 Add options callback to Encore.enableLessLoader() by Lyrkan · Pull Request #134 · symfony/webpack-encore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add options callback to Encore.enableLessLoader() #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2017
Merged

8000 Add options callback to Encore.enableLessLoader() #134

merged 1 commit into from
Aug 9, 2017

Conversation

Lyrkan
Copy link
Collaborator
@Lyrkan Lyrkan commented Aug 5, 2017

This PR allows to add a callback as the first argument of Encore.enableLessLoader() (fixes #118).
I didn't notice that one was missing too when working on #130.

Example :

Encore.enableLessLoader((options) => {
    options.relativeUrls = false;
});

@weaverryan
Copy link
Member

Brilliant! Thank you @Lyrkan!

@weaverryan weaverryan merged commit fdf72da into symfony:master Aug 9, 2017
weaverryan added a commit that referenced this pull request Aug 9, 2017
@weaverryan
feature #134 Add options callback to Encore.enableLessLoader() (Lyrkan)
c2f6012 
This PR was merged into the master branch.

Discussion
----------

Add options callback to Encore.enableLessLoader()

This PR allows to add a callback as the first argument of `Encore.enableLessLoader()` (fixes #118).
I didn't notice that one was missing too when working on #130.

Example :

```js
Encore.enableLessLoader((options) => {
    options.relativeUrls = false;
});
```

Commits
-------

fdf72da Add options callback to Encore.enableLessLoader()
@Lyrkan Lyrkan deleted the add-less-loader-options branch August 9, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Less-Loader, we need the "relativeUrls" option !
2 participants
@Lyrkan @weaverryan
0