Guarded miniz.c #define WIN32_LEAN_AND_MEAN against duplicates
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guarded `#define WIN32_LEAN_AND_MEAN` against duplicates
There was a problem hiding this comment.
Pull Request Overview
Adds a guard around the #define WIN32_LEAN_AND_MEAN to prevent duplicate macro definitions before including <windows.h>.
- Wraps the
#define WIN32_LEAN_AND_MEANin#ifndef/#endif - Keeps
#include <windows.h>unconditional
Comments suppressed due to low confidence (1)
deps/miniz/miniz.c:3069
- [nitpick] Adjust the indentation of the
#definedirective to match the surrounding preprocessor directives (#ifndef/#endif) for consistency.
#define WIN32_LEAN_AND_MEAN
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.