Star to Bookmark MUCs #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,6 +92,11 @@ QtChatWindow::QtChatWindow(const QString& contact, QtChatTheme* theme, UIEventSt | |||
| subjectLayout_->addWidget(subject_); | |||
| setSubject(""); | |||
| subject_->setReadOnly(true); | |||
|
|
|||
| bookmarkStar_ = new QPushButton(this); | |||
| connect(bookmarkStar_, SIGNAL(clicked()), this, SLOT(onBookmarkStarClicked())); | |||
There was a problem hiding this comment.
Our convention for slot names is a 'handle' prefix instead of 'on'. See the other slots used in this file.
|
Finally it would be great if you could license the PR under the BSD license by adding to the commit message, similar to danielbcs@f34a0eb . |
|
@tfar Please Checkout the new commit. It includes the changes you suggested. Thanks for your help & feedback! |
|
@urvashipriyam any news on this? IIRC you wanted to change the code to use a QCheckBox instead like it's done in https://github.com/swift/swift/blob/master/Swift/QtUI/QtVCardWidget/QtVCardGeneralField.cpp#L35 to allow quick change between bookmarked/not-bookmark states without having to go through a dialog. |
…rk And Remove Bookmark from MUC
…a particular room when star unchecked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a star to the top bar of a MUC (beside the subject). It's grey when the MUC isn't bookmarked, and yellow if it is. Clicking it pops up the add bookmark/edit bookmark properties.
License:
This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details.