8000 fix(ts/isolated-dts): Skip parameters without accessibility modifiers in private constructors by magic-akari · Pull Request #10675 · swc-project/swc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ts/isolated-dts): Skip parameters without accessibility modifiers in private constructors #10675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2025
Merged

fix(ts/isolated-dts): Skip parameters without accessibility modifiers in private constructors #10675

merged 2 commits into from
Jun 22, 2025
+37 −5

Conversation

magic-akari
Copy link
Member

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8e27174

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magic-akari magic-akari requested a review from CPunisher June 22, 2025 05:15
@magic-akari magic-akari marked this pull request as ready for review June 22, 2025 05:15
@magic-akari magic-akari requested a review from a team as a code owner June 22, 2025 05:15
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10675 will not alter performance

Comparing magic-akari:fix/issue-10674 (8e27174) with main (cac651b)

Summary

✅ 140 untouched benchmarks

CPunisher
CPunisher previously approved these changes Jun 22, 2025
View reviewed changes
@kdy1 kdy1 added this to the Planned milestone Jun 22, 2025
@kdy1 kdy1 merged commit 1976d8e into swc-project:main Jun 22, 2025
18 checks passed
@magic-akari magic-akari deleted the fix/issue-10674 branch June 22, 2025 07:09
@kdy1 kdy1 modified the milestones: Planned, v1.12.6 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPunisher CPunisher CPunisher left review comments

Assignees
No one assigned
Labels
None yet
Milestone
v1.12.6
Development

Successfully merging this pull request may close these issues.

[isolatedDeclarations] transform fails if a parameter on a private constructor has no annotation
3 participants
@magic-akari @CPunisher @kdy1
0