8000 fix(es/parser): Allow type ann in jsx expr child by bvanjoi · Pull Request #10626 · swc-project/swc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(es/parser): Allow type ann in jsx expr child #10626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

fix(es/parser): Allow type ann in jsx expr child #10626

merged 2 commits into from
Jun 18, 2025
+20 −28

Conversation

bvanjoi
Copy link
Contributor
@bvanjoi bvanjoi commented Jun 18, 2025

@bvanjoi bvanjoi requested a review from a team as a code owner June 18, 2025 13:35
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 18, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 00f4aa4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Jun 18, 2025
@kdy1 kdy1 requested a review from a team as a code owner June 18, 2025 13:38
@kdy1 kdy1 changed the title fix(es/parser): allow ty anno in jsx expr child fix(es/parser): Allow type ann in jsx expr child Jun 18, 2025
@kdy1 kdy1 enabled auto-merge (squash) June 18, 2025 13:39
@kdy1 kdy1 mentioned this pull request Jun 18, 2025
Open
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 18, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10626 will improve performances by 9.18%

Comparing bvanjoi:fix-jsx-expr (00f4aa4) with main (d8e2405)

Summary

⚡ 13 improvements
✅ 127 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ es/codegen/with-parser/colors 181.1 µs 175.2 µs +3.36%
⚡ es/codegen/with-parser/large 1.4 ms 1.3 ms +4.57%
⚡ es/parser/angular 27.4 ms 25.8 ms +6.48%
⚡ es/parser/backbone 4.3 ms 4 ms +6.65%
⚡ es/parser/cal-com 84.9 ms 77.7 ms +9.18%
⚡ es/parser/colors 113.5 µs 109.3 µs +3.84%
⚡ es/parser/jquery 22 ms 20.5 ms +7.02%
⚡ es/parser/jquery mobile 34 ms 31.8 ms +7.09%
⚡ es/parser/mootools 17.3 ms 16.1 ms +7.38%
⚡ es/parser/three 104.3 ms 97.8 ms +6.62%
⚡ es/parser/typescript 591.2 ms 555.5 ms +6.42%
⚡ es/parser/underscore 3.7 ms 3.5 ms +6.64%
⚡ es/parser/yui 16.8 ms 15.7 ms +7.09%

@kdy1 kdy1 disabled auto-merge June 18, 2025 16:27
@kdy1 kdy1 merged commit 48f576c into swc-project:main Jun 18, 2025
168 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.12.2 Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.12.2
Development

Successfully merging this pull request may close these issues.
2 participants
@bvanjoi @kdy1
0