8000 fix(@swc/types): Remove `nativeClassProperties` by CodeMan62 · Pull Request #10592 · swc-project/swc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(@swc/types): Remove 8000 nativeClassProperties #10592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2025
Merged

fix(@swc/types): Remove nativeClassProperties #10592

merged 4 commits into from
Jun 11, 2025
+24 −28

Conversation

CodeMan62
Copy link

closes #10589

@CodeMan62 CodeMan62 requested a review from a team as a code owner June 9, 2025 18:11
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5b61044

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CodeMan62 CodeMan62 changed the title remove nativeClassProperties from @swc/types remove nativeClassProperties from @swc/types Jun 9, 2025
@kdy1 kdy1 added this to the Planned milestone Jun 9, 2025
@kdy1 kdy1 requested a review from magic-akari June 9, 2025 19:10
@kdy1
Copy link
Member
kdy1 commented Jun 9, 2025

Is this what you intended? I'm not sure if typescript-wasm would be fine with this change

magic-akari
magic-akari requested changes Jun 10, 2025
View reviewed changes
@CodeMan62
Copy link
Author

Is this what you intended? I'm not sure if typescript-wasm would be fine with this change

Sorry i made a mistake i was not intended to remove the rs file code

@CodeMan62
Copy link
Author

I think now we can merge it

@kdy1 kdy1 requested a review from magic-akari June 10, 2025 22:59
@kdy1 kdy1 changed the title remove nativeClassProperties from @swc/types fix(@swc/types): Remove nativeClassProperties Jun 11, 2025
@kdy1 kdy1 merged commit 39032dc into swc-project:main Jun 11, 2025
166 checks passed
@kdy1
Copy link
Member
kdy1 commented Jun 11, 2025

I'll publish this PR tomorrow

@kdy1 kdy1 modified the milestones: Planned, v1.12.1 Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magic-akari magic-akari magic-akari approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

nativeClassProperties should be removed from @swc/types
3 participants
@CodeMan62 @kdy1 @magic-akari
0