8000 refactor(es/parser): Remove `cur!(false)` macro by bvanjoi · Pull Request #10583 · swc-project/swc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(es/parser): Remove cur!(false) macro #10583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

bvanjoi
Copy link
Contributor
@bvanjoi bvanjoi commented Jun 8, 2025

try removing cur!($parser, false) since in most cases it's unnecessary to generate the error structure at this point.

@bvanjoi bvanjoi requested a review from a team as a code owner June 8, 2025 09:53
Copy link
changeset-bot bot commented Jun 8, 2025

⚠️ No Changeset found

Latest commit: 1475cf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
codspeed-hq bot commented Jun 8, 2025

CodSpeed Performance Report

Merging #10583 will improve performances by 4.45%

Comparing bvanjoi:refactor-parser (1475cf4) with main (e1f2597)

Summary

⚡ 2 improvements
✅ 142 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 3 µs 2.9 µs +2.01%
es/lints/libs/terser 30.4 ms 29.1 ms +4.45%

@kdy1 kdy1 added this to the Planned milestone Jun 10, 2025
@kdy1 kdy1 changed the title refactor(es/parser): rm cur false macro refactor(es/parser): Remove cur!(false) macro Jun 10, 2025
@kdy1 kdy1 merged commit c96fa23 into swc-project:main Jun 10, 2025
169 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.12.0 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0