8000 refactor(swc_common): Use `BytesStr` instead of `Lrc<String>` by kdy1 · Pull Request #10580 · swc-project/swc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(swc_common): Use BytesStr instead of Lrc<String> #10580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Jun 9, 2025
Merged

refactor(swc_common): Use BytesStr instead of Lrc<String> #10580

merged 43 commits into from
Jun 9, 2025
+2,932 −2,262

Conversation

kdy1
Copy link
Member
@kdy1 kdy1 commented Jun 6, 2025

Description:

This is more efficient variant of Arc

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jun 6, 2025
@kdy1 kdy1 self-assigned this Jun 6, 2025
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 90472d3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review June 6, 2025 18:40
@kdy1 kdy1 requested review from a team as code owners June 6, 2025 18:40
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 6, 2025
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 6, 2025
View reviewed changes
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10580 will degrade performances by 5.83%

Comparing kdy1/bytes (90472d3) with main (a00a0f2)

Summary

❌ 1 regressions
✅ 139 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ es2020_nullish_coalescing 305.4 µs 324.3 µs -5.83%

kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 9, 2025
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 9, 2025
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 9, 2025
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) June 9, 2025 17:27
@kdy1 kdy1 disabled auto-merge June 9, 2025 17:28
@kdy1 kdy1 enabled auto-merge (squash) June 9, 2025 17:28
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 9, 2025
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 9, 2025
View reviewed changes
@kdy1 kdy1 merged commit 6f00973 into main Jun 9, 2025
154 of 168 checks passed
@kdy1 kdy1 deleted the kdy1/bytes branch June 9, 2025 18:45
@kdy1 kdy1 mentioned this pull request Jun 9, 2025
Merged
kdy1 added a commit to swc-project/swc-sourcemap that referenced this pull request Jun 9, 2025
@kdy1
refactor: Use BytesStr instead of Arc<str> (#1)
acd7bbb 
`BytesStr` is a more efficient variant of `Arc<str>`

Since swc-project/swc#10580, SWC also uses it to store the source map strings
@kdy1 kdy1 modified the milestones: Planned, v1.12.0 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1
0