8000 refactor(es/parser): Share code for parsing strings by bvanjoi · Pull Request #10522 · swc-project/swc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(es/parser): Share code for parsing strings #10522

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

bvanjoi
Copy link
Contributor
@bvanjoi bvanjoi commented May 26, 2025

No description provided.

@bvanjoi bvanjoi requested a review from a team as a code owner May 26, 2025 10:21
Copy link
changeset-bot bot commented May 26, 2025

🦋 Changeset detected

Latest commit: 6875c05

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
codspeed-hq bot commented May 26, 2025

CodSpeed Performance Report

Merging #10522 will degrade performances by 4.2%

Comparing bvanjoi:parser-2 (6875c05) with main (1c02ef6)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 142 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.9 µs 2.9 µs +2.03%
es/lints/libs/d3 27.4 ms 28.6 ms -4.2%

@CPunisher CPunisher changed the title refactor(ecma/parser): common parse str lit perf(ecma/parser): common parse str lit May 26, 2025
CPunisher
CPunisher previously approved these changes May 26, 2025
@kdy1 kdy1 changed the title perf(ecma/parser): common parse str lit refactor(es/parser): Share code for parsing strings May 26, 2025
@kdy1 kdy1 requested a review from a team as a code owner May 26, 2025 14:25
@kdy1 kdy1 added this to the Planned milestone May 26, 2025
@kdy1 kdy1 merged commit 931a2d6 into swc-project:main May 26, 2025
18 checks passed
@kdy1 kdy1 modified the milestones: Planned, Next version May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0