fix(resolver): avoid accessing properties of undefined or null parameters #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
reviewed
May 20, 2025
| @@ -85,10 +85,12 @@ export default function normalize(parsedSpec) { | |||
| for (const param of inherits[inheritName]) { | |||
| const exists = operation[inheritName].some( | |||
| (opParam) => | |||
There was a problem hiding this comment.
The business logic checks out. Maybe a more safer alternative of the code?
if (!Array.isArray(operation[inheritName])) {
operation[inheritName] = inherits[inheritName];
} else if (inheritName === 'parameters') {
// eslint-disable-next-line no-restricted-syntax
for (const param of inherits[inheritName]) {
const exists = operation[inheritName].some((opParam) => {
if (!isPlainObject(opParam) && !isPlainObject(param)) return false;
if (opParam === param) return true;
return ['name', '$ref', '$$ref'].some(
(key) =>
typeof opParam[key] === 'string' &&
typeof param[key] === 'string' &&
opParam[key] === param[key]
);
});
if (!exists) {
operation[inheritName].push(param);
}
}
}
swagger-bot
pushed a commit
that referenced
this pull request
May 20, 2025
## [3.35.2](v3.35.1...v3.35.2) (2025-05-20) ### Bug Fixes * **resolver:** avoid accessing properties of undefined or null parameters ([#3927](#3927)) ([dc04c99](dc04c99))
|
🎉 This PR is included in version 3.35.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes acessing properties of empty parameters during normalization, e.g.: