Unix packages (tar, rpm, deb) & some Unix installation fixes #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty good to me. I'll wait for @svkaiser to look at this since I haven't touched the project in ages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Deep respect for your work on doom64. Some things in this PR :
Avoid propagating
make installto fluidsynth as deploying fluidsynth headers (/usr[/local]/include/fluidsynth*) is not required by doom64ex and it could eventually conflicts with distro versions.Install doom64ex in
/usr[/local]/gamesinstead of/usr[/local]/binon unix targets.Install icon, manpage and desktop file on unix targets.
Implement
make packageon unix targets, that creates tar archives, deb and rpm packages. (Issue [Enhancement] Linking to Linux builds or using buildbot #48)I work with Ubuntu 18.04, the deb package seems to be ok, the rpm seems to be quite identical but I have not tested it.