feat: add fragmentIdentifier option
#33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasvn
added a commit
to tomasvn/svgstore
that referenced
this pull request
Jun 3, 2025
|
@weizhenye I've implemented your suggestion, and released a fork of svgstore package, https://www.npmjs.com/package/@tomasvn/svgstore try it, if you still needed, I might use it as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #24
SVG file may lack of
width,height,viewBoxattributes, it's hard to get width and height from SVG file without render it, so I introduce @resvg/resvg-js library to calc them.For now SVG Fragment Identifiers feature is opt-in,
<symbol>is still work, soidof<view>should not be same with<symbol>, it requires a custom function to get<view>'sid. Another way is treat SVG Fragment Identifiers as another mode which don't setidto<symbol>, only<view>works. I'm not sure which it better, what do you think?I'm not a native English speaker, edits in REAME may not precise, feel free to edit it.