feat: use access token from ram instead of from auth.getSession()
#15933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
48d7ede to
46c1e67
Compare
alaister
reviewed
Jul 21, 2023
Comment on lines
+92
to
+94
| auth.onAuthStateChange((event, session) => { | ||
| currentSession = session | ||
| }) |
There was a problem hiding this comment.
Is this 100% safe to call on the server? Could always do something like:
Suggested change
| auth.onAuthStateChange((event, session) => { | |
| currentSession = session | |
| }) | |
| if (typeof window !== 'undefined') { | |
| auth.onAuthStateChange((event, session) => { | |
| currentSession = session | |
| }) | |
| } |
There was a problem hiding this comment.
It is, it just registers a callback.
alaister
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#getSession()in gotrue-js can be a bit slow as it has to read fromlocalStorageall the time to make sure it's returning consistent data. With some changes that are coming (see #15795) it's going to be even slower as there would only be a single such call per tab.By storing and using the access token as seein in
onAuthStateChangednotifications, issues of slowness or concurrent access will be significantly reduced. This is absolutely safe, as any tab that changes the session broadcasts the changes to other tabs. This might significantly reduce the reported occurrence of random logouts when using the SQL editor.