[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dropping table triggers w/o being owners #90

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

soedirgo
Copy link
Member

What kind of change does this PR introduce?

feature

What is the current behavior?

The TRIGGER table privilege is inconsistent in that it allows roles to create triggers on tables, but doesn't allow them to drop said triggers. This prevents use cases such as allowing users to manage triggers on auth.users, realtime.messages, etc. without giving them table ownership.

What is the new behavior?

The new config supautils.drop_trigger_grants achieves this in a similar fashion to #85

Base automatically changed from chore/extract-common-tests to master September 25, 2024 18:41
@soedirgo soedirgo force-pushed the feat/allow-drop-triggers branch from 11a7daa to d0fc6c5 Compare September 25, 2024 18:43
Copy link
Member
@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code is straightforward.

(Sorry for the late review here)

@soedirgo soedirgo merged commit 2ecc6ae into master Oct 2, 2024
4 checks passed
@soedirgo soedirgo deleted the feat/allow-drop-triggers branch October 2, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants