Add stricter template and webspace key validation #7981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81ac117 to
175c731
Compare
55b5cd4 to
f8470aa
Compare
f8470aa to
0eb49c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add strictor template and webspace key validation
Why?
To be discussed, previously specially on jackrabbit there where no limits in length. On doctrine dbal the lenght limit was by the phpcr path limit (191 on mysql utf8mb4, 255 other ways). As a combined index can not be longer on 191 we need kind of limit the template and webspace key for efficient filtering that queries can using indexes. The longer the key the less other fields e.g. url match
slug,webspacekey,localee.g. for route matching can be.Common filters: