Add new properties parser which returns new metadata #7943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-63
to
-70
| /** | ||
| * @param ContentItemMetadata[] $itemsMetadata | ||
| */ | ||
| public function mapSchema(array $itemsMetadata): SchemaMetadata | ||
| { | ||
| return new SchemaMetadata($this->mapSchemaProperties($itemsMetadata)); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the only method we may still require. As discussed with @Prokyonn we are moving this into an own SchemaMetadataProvider service which is build ontop of the new metadata and not the old one. We use that service then in the formxmlloader and in the future templatexmlloader (currently structurexmlloader)
49dd444 to
4565102
Compare
4565102 to
717fd56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add new properties parser which returns new metadata.
Why?
Example Usage
This is more internal service. External service should get the metadata via the
MetadataProviderRegistryservice instead of using the underlaying services.To Do
mapPropertyMetadatasimilar to old and imagemap integrationSchemaMetadataProvidertests, see removed FormMetadataMapperTest.php Schema tests