Make backwards compatibility virtual parameters real #7936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
mamazu
force-pushed
the
make_parameter_real
branch
2 times, most recently
from
May 2, 2025 12:42
alexander-schranz
changed the title
Make parameters real again
Make backwards cmpatibile virtual parameters real
May 2, 2025
alexander-schranz
changed the title
Make backwards cmpatibile virtual parameters real
Make backwards compatibility virtual parameters real
May 2, 2025
mamazu
force-pushed
the
make_parameter_real
branch
from
May 2, 2025 13:18
ed2c2e4 to
701584d
Compare
701584d to
bda28e7
Compare
mamazu
commented
May 2, 2025
| @@ -68,15 +68,8 @@ public function __construct( | |||
| $this->logger = $logger ?: new NullLogger(); | |||
| } | |||
|
|
|||
| public function returnImage($id, $formatKey, $fileName /*, int<1, max>|null $version = null */) | |||
| public function returnImage($id, $formatKey, $fileName, ?int $version) | |||
There was a problem hiding this comment.
This parameter should not be nullable, but seeing that this would need a refactor of the FormatManager I've kept it nullable.
For Context: If the version is null then it will return the latest version (which is what we use in the FormatCacheRegenerate) If the version is not set to the current version, then it returns a redirect (very coupled with http). So maybe this method should be split up.
mamazu
commented
May 2, 2025
Comment on lines
-26
to
-35
| public function testConvert(): void | ||
| { | ||
| $tagManager = $this->prophesize(TagManager::class); | ||
| $tagsConverter = new TagsConverter($tagManager->reveal()); | ||
|
|
||
| $tagManager->resolveTagNames(['Tag1', 'Tag2', 'Tag3'])->willReturn([1, 2, 3]); | ||
|
|
||
| $this->assertEquals([1, 2, 3], $tagsConverter->convert(['Tag1', 'Tag2', 'Tag3'])); | ||
| } | ||
|
|
There was a problem hiding this comment.
This behaviour has been removed. Since we always have to pass 2 parameters to the function and then the output has a completely different shape.
bda28e7 to
4cabd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Making optional Parameters in 2.6 now required.
Why?
PHPstan does not like when the parameters aren't officially there.