8000 📝(docs) minor fixes to docs/env.md by bzg · Pull Request #1086 · suitenumerique/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

📝(docs) minor fixes to docs/env.md #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

bzg
Copy link
Collaborator
@bzg bzg commented Jun 19, 2025

Replaces #941

@bzg bzg force-pushed the documentation-env-fixes-take-2 branch from c419d5a to d7dffa7 Compare June 19, 2025 19:24
@bzg bzg requested a review from AntoLC June 19, 2025 21:51
@bzg
Copy link
Collaborator Author
bzg commented Jun 19, 2025

It feels like a waste of CPUs to run GitHub actions for such small changes.

Maybe we could conditionally run tests based on the extension of the modified files?

@lunika
Copy link
Member
lunika commented Jun 20, 2025

Your commit is still not signed with a pgp or ssh key.

Sort environment variables alphabetically and fix spelling.

Signed-off-by: Bastien Guerry <bastien.guerry@code.gouv.fr>
@bzg bzg force-pushed the documentation-env-fixes-take-2 branch from d7dffa7 to eee19c5 Compare June 20, 2025 11:16
@bzg
Copy link
Collaborator Author
bzg commented Jun 20, 2025

Sorry for the mishap, done now.

Copy link
Collaborator
@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard life, your commit is signed but unverified:
image

Did you add your key here https://github.com/settings/keys ?

@bzg
Copy link
Collaborator Author
bzg commented Jun 20, 2025

Fixed now.

@virgile-dev virgile-dev merged commit c3f81c2 into main Jun 20, 2025
20 of 21 checks passed
@virgile-dev virgile-dev deleted the documentation-env-fixes-take-2 branch June 20, 2025 13:53
@AntoLC AntoLC added the documentation Improvements or additions to documentation label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0