Finalize changes for first pass of metrics processor SDK + updated README.md #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheffner
approved these changes
Jun 22, 2025
| ] | ||
| # Add trace context for this exemplar | ||
| exemplar1.trace_id = b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10' | ||
| exemplar1.span_id = b'\x11\x12\x13\x14\x15\x16\x17\x18' |
There was a problem hiding this comment.
How would a user typically set these values to actual trace/span ids?
There was a problem hiding this comment.
Oh yeah, if you haven't checked them out yet it's worth googling. The SDK provides them either by a filter or a reservoir (for tail sampling) iirc. This example is a bit contrived as it's a demonstration on exercising the API. However your question is interesting because theoretically if rotel is deployed side by side with an application you could theoretically use additional libraries to store and fetch some additional data to use as exemplars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes: STR-3466, STR-3463
Couple extra stragglers tasked missed on the last PR for supporting metrics. Needed to update the cli arguments to be able to pass metrics processors and implementation of the
PythonProcessablefor ResourceMetrics. Additionally we've updated the README.md on both the main page and the SDK README. Up next cut a release of both rotel and rotel-sdk and then update rotel.dev docs.