8000 Add "useNewUrlParser" Mongoose connection option by techguydave · Pull Request #1537 · strapi/strapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add "useNewUrlParser" Mongoose connection option #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2018
Merged

Add "useNewUrlParser" Mongoose connection option #1537

merged 2 commits into from
Jul 10, 2018

Conversation

techguydave
Copy link
Contributor

My PR is an:
💅 Enhancement

Main update on the:
Framework

Adds the useNewUrlParser option to prevent the URL string parser warning. Since Strapi already adheres to the new parser's current changes (forcing the port into the connection URL), this is not a breaking change. Fixes #1532.

@techguydave
Copy link
Contributor Author

Currently this fixes strapi start, but I struggled trying to get it to fix strapi new. Going to need assistance figuring that part out, but this should be a good start.

@lauriejim lauriejim self-assigned this Jul 9, 2018
@lauriejim lauriejim added pr: 💅 Enhancement source: core:strapi Source is core/strapi package labels Jul 9, 2018
@lauriejim
Copy link
Contributor

You already did the job I think for strapi new. You are just natively not able to test it because strapi-mongoose is not published with your update.

When you run strapi new it will run npm i strapi-mongoose@alpha to test your MongoDB connection. And your update is not downloaded.

It's why we use Verdaccio to have a private NPM registry to test this kind f things. We write an article about this.

@techguydave
Copy link
Contributor Author

Ah, that makes sense. Thank you for confirming I'm not crazy! At least, not in this instance.

@techguydave techguydave changed the title [WIP] Add "useNewUrlParser" Mongoose connection option Add "useNewUrlParser" Mongoose connection option Jul 9, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.12.7 milestone Jul 10, 2018
@lauriejim lauriejim merged commit a7c505f into strapi:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauriejim lauriejim lauriejim approved these changes

Assignees

@lauriejim lauriejim

Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
3.0.0-alpha.12.7
Development

Successfully merging this pull request may close these issues.
2 participants
@techguydave @lauriejim
0