8000 Support and default to none attestation by nsatragno · Pull Request #19 · strangerlabs/webauthn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support and default to none attestation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2020
Merged

Support and default to none attestation #19

merged 3 commits into from
Jan 4, 2020

Conversation

nsatragno
Copy link
Contributor
@nsatragno nsatragno commented Dec 30, 2019 •
edited
Loading

Add support for 'none' attestation. Consider it valid if the webauthn
config sets the conveyance preference to none.

This change also shuffles some code around to avoid repetition when
verifying the MakeCredential attestation.

Fixes #18 and #11

Depends on #17

@nsatragno
[Example] Add a development workflow
8273b8d 
Add a script to the example app that runs the server in port :3001, and
proxy requests from `react-scripts start` to it. This allows running the
example in an unoptimized mode suitable for development.

Fixes strangerlabs#16
@nsatragno
Support and default to none attestation
4654320 
Add support for 'none' attestation. Consider it valid if the webauthn
config sets the conveyance preference to none.

This change also shuffles some code around to avoid repetition when
verifying the MakeCredential attestation.

Fixes strangerlabs#18
@nsatragno
Add docs.
c60ae9c
@nsatragno nsatragno marked this pull request as ready for review December 30, 2019 23:16
EternalDeiwos
EternalDeiwos approved these changes Jan 4, 2020
View reviewed changes
Copy link
Contributor
@EternalDeiwos EternalDeiwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Terrahop
Terrahop approved these changes Jan 4, 2020
View reviewed changes
Copy link
@Terrahop Terrahop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me 👍

@EternalDeiwos EternalDeiwos mentioned this pull request Jan 4, 2020
Closed
@EternalDeiwos EternalDeiwos merged commit d3e788d into strangerlabs:master Jan 4, 2020
@EternalDeiwos EternalDeiwos mentioned this pull request Jan 4, 2020
Closed
@nsatragno nsatragno deleted the none_attestation branch January 6, 2020 23:15
@EternalDeiwos EternalDeiwos mentioned this pull request Jan 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EternalDeiwos EternalDeiwos EternalDeiwos approved these changes

@Terrahop Terrahop Terrahop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support and default to none attestation
3 participants
@nsatragno @EternalDeiwos @Terrahop
0