10000 Fix Port::command_reply_infos by stphnt · Pull Request #115 · stphnt/zproto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Port::command_reply_infos #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2023
Merged

Fix Port::command_reply_infos #115

merged 2 commits into from
Sep 30, 2023

Conversation

stphnt
Copy link
Owner
@stphnt stphnt commented Sep 30, 2023

Fixes #113

@stphnt stphnt self-assigned this Sep 30, 2023
@stphnt stphnt force-pushed the fix-command_reply_infos branch from cc269a8 to c3ccfcf Compare September 30, 2023 06:19
@stphnt stphnt force-pushed the fix-command_reply_infos branch from c3ccfcf to 80f0dd0 Compare September 30, 2023 06:21
@stphnt stphnt enabled auto-merge September 30, 2023 06:22
@stphnt stphnt force-pushed the fix-command_reply_infos branch from 80f0dd0 to 03ca623 Compare September 30, 2023 06:24
@stphnt
Use custom check in Port::command_reply_infos_with_check
c655a3d 
Previously only the info messages and sentinel reply were checked with
the custom check, but the reply to the original command used the default
check. This corrects this mistake, using the custom check for all
responses.
@stphnt stphnt force-pushed the fix-command_reply_infos branch from 03ca623 to c655a3d Compare September 30, 2023 06:28
@stphnt stphnt merged commit ff37f3c into main Sep 30, 2023
@stphnt stphnt deleted the fix-command_reply_infos branch September 30, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stphnt stphnt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port::command_reply_with_check does not use the custom check on the command
1 participant
@stphnt
0