Refactor the ascii::Target API
#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edb5cf5 to
5dc5ad9
Compare
The previous API was a mix of constructors and getters. However, the constructors looked like getters and the getters didn't follow the Rust API guidelines (they started with `get_`). This change makes the constructors read more clearly as constructors and makes the getters follow the API guidelines. It also expands the documentation to avoid confusion.
5dc5ad9 to
1f749b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous API was a mix of constructors and getters. However, the constructors looked like getters, the getters didn't follow the Rust API guidelines (they started with
get_). This change makes the constructors read more clearly as constructors and makes the getters follow the API guidelines. It also expands the documentation to avoid confusion.Closes #86