8000 TIM10-14 OPM by burrbull · Pull Request #684 · stm32-rs/stm32-rs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TIM10-14 OPM #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2022
Merged

TIM10-14 OPM #684

merged 4 commits into from
Apr 17, 2022

Conversation

burrbull
Copy link
Member

No description provided.

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

adamgreig
adamgreig reviewed Dec 31, 2021
View reviewed changes
Copy link
Member
@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the F0 and F1 so far, but it seems this adds OPM to lots of TIM10/11/13/14 that don't have the field on the RM. Is this intentional?

@burrbull
Copy link
Member Author

You are right saying about F0 TIM14.

But I can't find any timer in RM0008 and RM0041 for F1 without OPM.

@github-actions
Copy link

Memory map comparison

@adamgreig
Copy link
Member

Ah, I was looking at RM008 revision 16, and in revision 17 they updated TIM10/11/13/14 CR1 to add OPM 😩

@burrbull
Copy link
Member Author

Forgot to rebase on master. Fixed

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@burrbull burrbull mentioned this pull request Apr 16, 2022
Merged
richardeoin
richardeoin reviewed Apr 16, 2022
View reviewed changes
Copy link
Member
@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the whole PR, and it looks good except some more mismatches with the F3/F4 Reference Manuals and OPM bits. It's really chaotic sadly

devices/stm32f373.yaml Outdated
@@ -163,6 +163,7 @@ _include:
- ../peripherals/gpio/gpio_with_brr.yaml
- common_patches/f3_gpio_ospeedr.yaml
- common_patches/tim/tim_o24ce.yaml
- common_patches/tim/tim13_missing_opm.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM0313 Rev 6 shows no OPM bit in TIM13/14 (There is an OPM bit in TIM12)

devices/stm32f301.yaml Outdated
@@ -167,6 +167,7 @@ _include:
- ../peripherals/gpio/gpio_v2.yaml
- common_patches/f3_gpio_ospeedr.yaml
- common_patches/tim/tim_o24ce.yaml
- common_patches/tim/tim13_missing_opm.yaml
Copy link
Member
@richardeoin richardeoin Apr 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM0366 Rev 4 doesn't even include a TIM13/14(!) Removing the whole peripheral isn't needed for this PR, but I would suggest don't add the OPM bit

devices/stm32f412.yaml Outdated
@@ -430,11 +430,14 @@ _include:
- ../peripherals/dma/dma_v2.yaml
- ../peripherals/spi/spi_v1.yaml
- common_patches/tim/tim_o24ce.yaml
- common_patches/tim/tim10_missing_opm.yaml
- common_patches/tim/tim11_missing_opm.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F412 (RM0402 Rev 6) TIM10/11/13/14 does not have OPM

devices/stm32f410.yaml Outdated
6D40
@@ -184,9 +184,13 @@ _include:
- ../peripherals/dma/dma_v2.yaml
- ../peripherals/spi/spi_v1.yaml
- common_patches/tim/tim_o24ce.yaml
- common_patches/tim/tim11_missing_opm.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F410 (RM0401 Rev 3) TIM11 does not have OPM

devices/stm32f413.yaml Outdated
@@ -203,8 +209,11 @@ _include:
- ../peripherals/dma/dma_v21.yaml
- ../peripherals/spi/spi_v1.yaml
- common_patches/tim/tim_o24ce.yaml
- common_patches/tim/tim10_missing_opm.yaml
- common_patches/tim/tim11_missing_opm.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F413 (RM0430 Rev 8) TIM10/11/13/14 does not have OPM

9E88 devices/stm32f446.yaml Outdated
@@ -551,6 +551,8 @@ _include:
- ../peripherals/dma/dma_v2.yaml
- ../peripherals/spi/spi_v1.yaml
- common_patches/tim/tim_o24ce.yaml
- common_patches/tim/tim10_missing_opm.yaml
- common_patches/tim/tim11_missing_opm.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F446 (RM0390 Rev 6) does not have OPM

devices/stm32f469.yaml Outdated
@@ -146,6 +146,8 @@ _include:
- ../peripherals/dma/dma2d_v1.yaml
- ../peripherals/spi/spi_v1.yaml
- common_patches/tim/tim_o24ce.yaml
- common_patches/tim/tim10_missing_opm.yaml
- common_patches/tim/tim11_missing_opm.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F469 (RM0386 Rev 5) does not have OPM

@github-actions
Copy link

Memory map comparison

@burrbull
Copy link
Member Author

@richardeoin I slightly reworked PR and fixed according to your review 84f8b21

изображение

richardeoin
richardeoin approved these changes Apr 17, 2022
View reviewed changes
Copy link
Member
@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now

bors r+

@bors
Copy link
Contributor
bors bot commented Apr 17, 2022

Build succeeded:

@bors bors bot merged commit 267475d into stm32-rs:master Apr 17, 2022
@burrbull burrbull deleted the tims branch August 14, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig left review comments

@richardeoin richardeoin richardeoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @adamgreig @richardeoin
0