feat: migrate CLI to Cobra/Viper (#93) #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09f2860 to
bf4b3e9
Compare
frrist
commented
Jun 12, 2025
| @@ -1,41 +0,0 @@ | |||
| package main | |||
There was a problem hiding this comment.
I've assumed this was a one-off helper, and removed it, I don't see it referenced anywhere in the go code or terraform.
| @@ -48,7 +48,8 @@ func (p *PDPService) ProofSet(ctx context.Context, id int64) (*ProofSet, error) | |||
|
|
|||
| // Step 5: Build the response. | |||
| response := &ProofSet{ | |||
| ID: proofSet.ID, | |||
| ID: proofSet.ID, | |||
| // TODO this will panic if ProveAtEpoch is nill, which it is when the proofset is first created | |||
There was a problem hiding this comment.
Not caused by this change, but found during testing - #111
8585fd7 to
e535ce1
Compare
e535ce1 to
4dbe20b
Compare
hannahhoward
approved these changes
Jun 18, 2025
| `, | ||
| } | ||
|
|
||
| GenerateCmd = &cobra.Command{ |
There was a problem hiding this comment.
random formatting question -- why is generate declared up here but parse is declared below?
There was a problem hiding this comment.
Whoops, I got lazy, moved Parse to this same var declaration block.
cmd/api/client.go
Outdated
| @@ -0,0 +1,52 @@ | |||
| package api | |||
There was a problem hiding this comment.
just curious: how is this an API?
There was a problem hiding this comment.
ehh, it's not - naming is hard - renamed this to client.
…93) Restructure CLI with clear separation between server and client operations, replacing urfave/cli with Cobra and Viper for improved configuration management. Architecture changes: - Introduce `piri serve <ucan|pdp>` for running different server types: - `piri serve pdp`: Start PDP (Provable Data Possession) server - `piri serve ucan`: Start UCAN authorization server - Add `piri client` commands for interacting with servers: - `piri client upload`: Upload data to storage servers - `piri client pdp`: PDP-specific client operations - piece info/management - proofset create/get/status operations - Clear separation of concerns between server hosting and client interactions Configuration improvements: - Unified config system supporting TOML files, env vars (PIRI_), and CLI flags - Type-safe configuration with validation - Proper precedence: flags > env > config file > defaults
4dbe20b to
76a60c3
Compare
- all vas delcared together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure CLI with clear separation between server and client operations,
replacing urfave/cli with Cobra and Viper for improved configuration management.
Architecture changes:
piri serve <ucan|pdp>for running different server types:piri serve pdp: Start PDP (Provable Data Possession) serverpiri serve ucan: Start UCAN authorization serverpiri clientcommands for interacting with servers:piri client upload: Upload data to storage serverspiri client pdp: PDP-specific client operationsConfiguration improvements:
Closes #93