-
Notifications
You must be signed in to change notification settings - Fork 26
Update dependencies #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #351
Conversation
Something went wrong with PR preview build please check |
Preview is available here: |
let result; | ||
try { | ||
result = await keyManager.loadKey(id, password); | ||
} catch (error) { | ||
return error; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This try catch
was making returned type Error | Key
, which was creating problems down the line. We don't really need this try catch
here, because it's handled in submitPaymentTransaction()
here.
.eslintrc.js
Outdated
rules: { | ||
"no-console": "off", | ||
"import/no-unresolved": "off", | ||
"react/jsx-filename-extension": ["error", { extensions: [".tsx", ".jsx"] }], | ||
"no-plusplus": "off", | ||
"jsdoc/check-indentation": "off", | ||
camelcase: "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, why did this need to be disabled? Wondering if it's worth disabling it inline for whatever code is causing the error rather than turning it off altogether
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Will remove this and will fix inline as needed.
Preview is available here: |
Preview is available here: |
No description provided.