8000 Update dependencies by quietbits · Pull Request #351 · stellar/account-viewer-v2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update dependencies #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Update dependencies #351

merged 4 commits into from
Oct 7, 2021

Conversation

quietbits
Copy link
Contributor

No description provided.

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Comment on lines -80 to -85
let result;
try {
result = await keyManager.loadKey(id, password);
} catch (error) {
return error;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This try catch was making returned type Error | Key, which was creating problems down the line. We don't really need this try catch here, because it's handled in submitPaymentTransaction() here.

@quietbits quietbits requested a review from piyalbasu October 5, 2021 20:04
.eslintrc.js Outdated
rules: {
"no-console": "off",
"import/no-unresolved": "off",
"react/jsx-filename-extension": ["error", { extensions: [".tsx", ".jsx"] }],
"no-plusplus": "off",
"jsdoc/check-indentation": "off",
camelcase: "off",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why did this need to be disabled? Wondering if it's worth disabling it inline for whatever code is causing the error rather than turning it off altogether

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Will remove this and will fix inline as needed.

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@quietbits quietbits merged commit 4ad0643 into master Oct 7, 2021
@quietbits quietbits deleted the il-deps branch October 7, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0