Liquidity Pool transactions + Claimable balances #344
Conversation
|
Preview is available here: |
|
Preview is available here: |
|
Preview is available here: |
| export interface ClaimableBalancesInitialState { | ||
| data: ClaimableBalance[]; | ||
| status: ActionStatus | undefined; | ||
| errorString?: string; |
There was a problem hiding this comment.
in both of these, shouldn't it be
errorString: string | undefined?
Looks like the initial state defines errorString, so the key should always be present instead of optional
There was a problem hiding this comment.
That is a good point, we have done it this way in all other ducks. I'd prefer the more strict way and will create a separate ticket to update all for consistency.
| }, | ||
| public: { | ||
| url: "https://horizon.stellar.org", | ||
| network: StellarSdk.Networks.PUBLIC, | ||
| stellarExpertTxUrl: "https://stellar.expert/explorer/public/tx/", | ||
| stellarExpertAccountUrl: "https://stellar.expert/explorer/public/account/", | ||
| stellarExpertAssetUrl: "https://stellar.expert/explorer/public/asset/", | ||
| }, |
There was a problem hiding this comment.
should we set something like const STELLAR_EXPERT_URL = https://stellar.expert/explorer/
|
Preview is available here: |
|
Preview is available here: |
Uh oh!
There was an error while loading. Please reload this page.